Skip to content

Conversation

@wjunLu
Copy link
Collaborator

@wjunLu wjunLu commented Jan 7, 2026

What this PR does / why we need it?

Upgrade to:

  • CANN 8.5.0.alpha002
  • Torch 2.9.0
  • Torch-npu 2.9.0.dev20260108

With:

  • Triton-ascend 0105 / Bisheng 0105

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the CANN version from 8.3.rc2 to 8.5.0.alpha002 across various Dockerfiles, configuration files, and documentation. The changes are mostly straightforward version bumps. I've identified an outdated link in the README.md file that should be updated to reflect the new CANN version.

- Software:
* Python >= 3.10, < 3.12
* CANN == 8.3.rc2 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/83RC2/releasenote/releasenote_0000.html))
* CANN == 8.5.0.alpha002 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/83RC2/releasenote/releasenote_0000.html))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The link to the Ascend HDK release notes is outdated. While the CANN version has been updated to 8.5.0.alpha002, the link still points to the documentation for 8.3.RC2. This can be misleading for users. The URL should be updated to point to the correct release notes for the new version.

Suggested change
* CANN == 8.5.0.alpha002 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/83RC2/releasenote/releasenote_0000.html))
* CANN == 8.5.0.alpha002 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/8.5.0.alpha002/releasenote/releasenote_0000.html))

@github-actions github-actions bot added documentation Improvements or additions to documentation ci/build module:tests labels Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wjunLu wjunLu added ready read for review ready-for-test start test by label for PR labels Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

wjunLu and others added 2 commits January 9, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant