-
Notifications
You must be signed in to change notification settings - Fork 716
[Verify] Upgrade CANN 8.5.0.alpha002 #5688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the CANN version from 8.3.rc2 to 8.5.0.alpha002 across various Dockerfiles, configuration files, and documentation. The changes are mostly straightforward version bumps. I've identified an outdated link in the README.md file that should be updated to reflect the new CANN version.
| - Software: | ||
| * Python >= 3.10, < 3.12 | ||
| * CANN == 8.3.rc2 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/83RC2/releasenote/releasenote_0000.html)) | ||
| * CANN == 8.5.0.alpha002 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/83RC2/releasenote/releasenote_0000.html)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the Ascend HDK release notes is outdated. While the CANN version has been updated to 8.5.0.alpha002, the link still points to the documentation for 8.3.RC2. This can be misleading for users. The URL should be updated to point to the correct release notes for the new version.
| * CANN == 8.5.0.alpha002 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/83RC2/releasenote/releasenote_0000.html)) | |
| * CANN == 8.5.0.alpha002 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/8.5.0.alpha002/releasenote/releasenote_0000.html)) |
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: wjunLu <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: wjunLu <[email protected]>
Signed-off-by: wjunLu <[email protected]>
Signed-off-by: wjunLu <[email protected]>
…into upgrade_cann
What this PR does / why we need it?
Upgrade to:
With:
Does this PR introduce any user-facing change?
How was this patch tested?