[CI][Benchmark] Optimize performance benchmark workflow #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potabk
changed the title
Potabk
force-pushed
the
dev-bench
branch
2 times, most recently
from
78e396f to
2e124d4
Compare
github-actions
bot
added
the
documentation
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Potabk
changed the title
Potabk
changed the title
Signed-off-by: wangli <[email protected]>
Yikun
reviewed
Jun 3, 2025
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
wangxiyuan
approved these changes
Jun 3, 2025
Yikun
reviewed
Jun 3, 2025
| @@ -64,6 +64,7 @@ jobs: | |||
| env: | |||
| HF_ENDPOINT: https://hf-mirror.com | |||
| HF_TOKEN: ${{ secrets.HF_TOKEN }} | |||
| HF_HOME: /github/home/.cache/huggingface | |||
There was a problem hiding this comment.
Why we need specified explictly?
Yikun
reviewed
Jun 3, 2025
Signed-off-by: Yikun Jiang <[email protected]>
Yikun
added
performance-test
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 4, 2025
…#1039) ### What this PR does / why we need it? This is a post patch of vllm-project#1014, for some convenience optimization - Set cached dataset path for speed - Use pypi to install escli-tool - Add benchmark results convert script to have a developer-friendly result - Patch the `benchmark_dataset.py` to disable streaming load for internet - Add more trigger ways for different purpose, `pr` for debug, `schedule` for daily test, `dispatch` and `pr-labled` for manual testing of a single(current) commit - Disable latency test for `qwen-2.5-vl`, (This script does not support multi-modal yet) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: wangli <[email protected]> Signed-off-by: wangxiaoxin (A) <[email protected]>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 4, 2025
…#1039) This is a post patch of vllm-project#1014, for some convenience optimization - Set cached dataset path for speed - Use pypi to install escli-tool - Add benchmark results convert script to have a developer-friendly result - Patch the `benchmark_dataset.py` to disable streaming load for internet - Add more trigger ways for different purpose, `pr` for debug, `schedule` for daily test, `dispatch` and `pr-labled` for manual testing of a single(current) commit - Disable latency test for `qwen-2.5-vl`, (This script does not support multi-modal yet) No CI passed --------- Signed-off-by: wangli <[email protected]> Signed-off-by: wangxiaoxin (A) <[email protected]>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 4, 2025
…#1039) This is a post patch of vllm-project#1014, for some convenience optimization - Set cached dataset path for speed - Use pypi to install escli-tool - Add benchmark results convert script to have a developer-friendly result - Patch the `benchmark_dataset.py` to disable streaming load for internet - Add more trigger ways for different purpose, `pr` for debug, `schedule` for daily test, `dispatch` and `pr-labled` for manual testing of a single(current) commit - Disable latency test for `qwen-2.5-vl`, (This script does not support multi-modal yet) No CI passed --------- Signed-off-by: wangli <[email protected]> Signed-off-by: wangxiaoxin (A) <[email protected]>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 4, 2025
…#1039) This is a post patch of vllm-project#1014, for some convenience optimization - Set cached dataset path for speed - Use pypi to install escli-tool - Add benchmark results convert script to have a developer-friendly result - Patch the `benchmark_dataset.py` to disable streaming load for internet - Add more trigger ways for different purpose, `pr` for debug, `schedule` for daily test, `dispatch` and `pr-labled` for manual testing of a single(current) commit - Disable latency test for `qwen-2.5-vl`, (This script does not support multi-modal yet) No CI passed --------- Signed-off-by: wangli <[email protected]> Signed-off-by: wangxiaoxin (A) <[email protected]>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 5, 2025
…#1039) This is a post patch of vllm-project#1014, for some convenience optimization - Set cached dataset path for speed - Use pypi to install escli-tool - Add benchmark results convert script to have a developer-friendly result - Patch the `benchmark_dataset.py` to disable streaming load for internet - Add more trigger ways for different purpose, `pr` for debug, `schedule` for daily test, `dispatch` and `pr-labled` for manual testing of a single(current) commit - Disable latency test for `qwen-2.5-vl`, (This script does not support multi-modal yet) No CI passed --------- Signed-off-by: wangli <[email protected]> Signed-off-by: wangxiaoxin (A) <[email protected]>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 5, 2025
…#1039) This is a post patch of vllm-project#1014, for some convenience optimization - Set cached dataset path for speed - Use pypi to install escli-tool - Add benchmark results convert script to have a developer-friendly result - Patch the `benchmark_dataset.py` to disable streaming load for internet - Add more trigger ways for different purpose, `pr` for debug, `schedule` for daily test, `dispatch` and `pr-labled` for manual testing of a single(current) commit - Disable latency test for `qwen-2.5-vl`, (This script does not support multi-modal yet) No CI passed --------- Signed-off-by: wangli <[email protected]> Signed-off-by: wangxiaoxin (A) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This is a post patch of #1014, for some convenience optimization
benchmark_dataset.pyto disable streaming load for internetprfor debug,schedulefor daily test,dispatchandpr-labledfor manual testing of a single(current) commitqwen-2.5-vl, (This script does not support multi-modal yet)Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed