Skip to content

[Misc]: add unit test for aibrix metrics collector #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

googs1025
Copy link
Contributor

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: None

  • add unit test for aibrix metrics collector

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@googs1025 googs1025 force-pushed the unit/python branch 3 times, most recently from affdcd5 to a0960c8 Compare May 30, 2025 06:26
@Jeffwan
Copy link
Collaborator

Jeffwan commented Jun 4, 2025

I rerun the tests. seems it's still flaky

@googs1025
Copy link
Contributor Author

I rerun the tests. seems it's still flaky

but I saw ci tests all paas. 🤔

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jun 5, 2025

@googs1025 I mean the e2e flaky issues

@Jeffwan Jeffwan merged commit cc64f87 into vllm-project:main Jun 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants