test(rsc): add navigation example
#567
Draft
+719
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hi-ogawa I can't get npm run build/preview to work, although it was working on vite-plugins and hydration worked in that case. 
|
|
I'll continue work in vite-plugins PR for now because build/preview works there |
hi-ogawa
changed the title
hi-ogawa
changed the title
navigation example
|
Thanks for the PR! The build error was because there was a copy of The dev error is due to Vite's deps optimization. I added It looks like navigation has some issues (both dev and build) and also there's typescript error, which I'm not sure about. Please continue integration and feel free to ask me if anything unclear about Vite RSC. Thanks! |
|
@hi-ogawa Thank you, that's amazing 🙏 |
The built-in vite hydrate does too much - handles navigation, for example, which is no good because router needs to handle it
Also renamed to Shell to match other navigation rsc examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied over from vite-plugins.
Hi @hi-ogawa , thank you for working on a vite rsc implementation.
I'm the author of the Navigation router, an rsc framework for react. I'd already written example rsc apps to test out parcel and webpack. So I've started to do the same for your vite implementation. This PR isn't meant to be merged but is a good way to communicate any issues I find.
I cloned your basic example and copied in the files from my working parcel example. When I run
npm run devthe ssr works but the hydration fails. It fails because the react context isn't populated as expected. It seems like vite has 2 versions of the file - 1 inside the bundled navigation-react.js and one standalone. You can see in the screenshot below it says "from SceneRSCView" instead of "from navigation-react.js". The react context is created from navigation-react.js so it can't be found if it's not accessed the same way. This is just my guess as to what's going wrong.For some background, The
navigation-reactpackage has different exports for server and client and has internal client boundaries. TheSceneRSCView, where the error is happening, is one of these.Thanks again for all your work.