-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat: introduce experimental v3 native plugins #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolldown-vite
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -550,7 +550,7 @@ export interface ExperimentalOptions { | |||||||
| * | ||||||||
| * - 'resolver' (deprecated, will be removed in v8 stable): Enable only the native resolver plugin. | ||||||||
| * - 'v1' (will be deprecated, will be removed in v8 stable): Enable the first stable set of native plugins (including resolver). | ||||||||
| * - true: Enable all native plugins (currently an alias of 'v1', it will map to a newer one in the future versions). | ||||||||
| * - true: Enable all native plugins (including newly added ones beyond 'v1'). | ||||||||
| * | ||||||||
| * @experimental | ||||||||
| * @default 'v1' | ||||||||
|
|
@@ -768,7 +768,7 @@ const configDefaults = Object.freeze({ | |||||||
| importGlobRestoreExtension: false, | ||||||||
| renderBuiltUrl: undefined, | ||||||||
| hmrPartialAccept: false, | ||||||||
| enableNativePlugin: process.env._VITE_TEST_JS_PLUGIN ? false : 'v1', | ||||||||
| enableNativePlugin: process.env._VITE_TEST_JS_PLUGIN ? false : true, | ||||||||
| }, | ||||||||
| future: { | ||||||||
| removePluginHookHandleHotUpdate: undefined, | ||||||||
|
|
@@ -2060,8 +2060,9 @@ function resolveNativePluginEnabledLevel( | |||||||
| case 'resolver': | ||||||||
| return 0 | ||||||||
| case 'v1': | ||||||||
| case true: | ||||||||
| return 1 | ||||||||
| case true: | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
We should also update the jsdoc of
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm considering not adding the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think? @sapphi-red |
||||||||
| return 2 | ||||||||
| case false: | ||||||||
| return -1 | ||||||||
| default: | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be reverted before merging.