Open
Conversation
|
Why it's not merged yet?( |
Owner
|
Are you sure that negated gitignore patterns should not affect directories? For example when I run git status shows me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is an attempt at fixing include patterns in
.griveignorefollowing the discussion in bug #208.Basically, the patch assures that include patterns are converted into lookahead patterns terminated by
$in the regular expression used to sift the filenames.In this way if you have an include pattern (e.g.,
database), this only matchesdatabaserather thandatabaseand anything below it (as it is currently and incorrectly the case).If you want to include
databaseand anything below, then you should have!database**in your.griveignore.The patch also assures that the regular expression is printed when one asks for a verbose output, so that some debugging is possible.