[viogpu] Fix resource leak when framebuffer init fails

[xz-dev]

When VioGpuObj::Init() fails in CreateFrameBufferObj(), the GPU resource and ID allocated earlier are not cleaned up, causing host-side resource leak. Add DestroyResource() and PutId() calls before returning FALSE.

Test case, if no #1474 and then resize to something like 5486x2818

[gemini-code-assist]

Summary of Changes

Hello @xz-dev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical resource leak within the viogpu driver. Previously, if the initialization of a VioGpuObj failed during framebuffer creation, the GPU resource and its associated ID were not deallocated, leading to host-side resource exhaustion. The changes introduce proper cleanup calls in the error path, ensuring system stability and efficient resource management.

Highlights

• Resource Leak Fix: Addressed a resource leak that occurred when VioGpuObj::Init() failed during the creation of a framebuffer object, preventing GPU resources and IDs from being properly cleaned up.
• Error Handling Improvement: Implemented explicit calls to DestroyResource() and PutId() to ensure that allocated GPU resources and their identifiers are released before returning from CreateFrameBufferObj() on initialization failure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[YanVugenfirer]

[Jenkins CI]: Can one of the admins verify this patch?

[gemini-code-assist]

Code Review

This pull request correctly addresses a resource leak in VioGpuAdapter::CreateFrameBufferObj when VioGpuObj::Init() fails. The added cleanup logic for the GPU resource and ID is appropriate and fixes the bug described.

I noticed that a similar resource leak pattern exists in VioGpuAdapter::CreateCursor. In that function, if obj->Init() or GpuObjectAttach() fails, the allocated resource ID and the GPU resource are not released. It would be beneficial to address this in a follow-up change to improve the robustness of the driver.

[YanVugenfirer]

ok to test

[YanVugenfirer]

@xz-dev Thanks! Good catch!

Please check Gemini code review for possible additional place in the code with similar pattern.

[YanVugenfirer]

@xz-dev Sorry, I missed that the "Signed-off-by: Name " line is missing. Please add in all commits. It can be automated by git when you do "git commit" add "-s" command line parameter.

Thanks,
Yan

[xz-dev]

@xz-dev Thanks! Good catch!

Please check Gemini code review for possible additional place in the code with similar pattern.

No problem, I'll continue on January 2nd after I get back from my vacation.