This repository was archived by the owner on Dec 23, 2018. It is now read-only.
Open
Conversation
vfaronov
reviewed
Jun 27, 2018
Owner
vfaronov
left a comment
There was a problem hiding this comment.
Thank you for your effort. However, this needs more work.
When there’s an error in the rules code (during parsing or execution), Turq reports the error’s line number. With your change, that number becomes useless, because it’s now the line number in some concatenation of multiple files.
To deal with this properly, you would need to change how Turq parses and executes rules code and reports errors. And, as discussed in #11, I’m not sure this is a good idea for Turq.
There are also a few smaller problems with your code (missing paths are silently ignored; no tests; no docs).
If you like, feel free to try and improve this, but I can’t promise to merge this anytime soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the "-r --rules" arg, and add multi mock config file support
please refer to the issue @#11