Remove the last remaining linked lists from packer code - #3745
Open
AmirhosseinPoolad wants to merge 4 commits into
Open
Remove the last remaining linked lists from packer code#3745AmirhosseinPoolad wants to merge 4 commits into
AmirhosseinPoolad wants to merge 4 commits into
Conversation
github-actions
Bot
added
VPR
AlexandreSinger
left a comment
AlexandreSinger
left a comment
Contributor
There was a problem hiding this comment.
This has made the code so much cleaner! Thank you so much @AmirhosseinPoolad !
I had one small nit. Other than that it LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the last remaining linked lists in the packer code. Should resolve #2088 to the best of my knowledge but it's possible that I've missed something.