Support for link/router specific bandwidth/latency in architecture file #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), ProcessMode(), ProcessMetadata()
github-actions
bot
added
VPR
vaughnbetz
reviewed
May 27, 2024
| * @brief When set true, specifies that some NoC routers have different | ||
| * latencies than others. When set false, all the NoC routers have the same | ||
| * latency. | ||
| */ |
There was a problem hiding this comment.
Comment why these variables are useful / what they control (probably better to comment here than in the .cpp).
|
Should also do a QoR test on the router suite just to be sure it is OK. |
|
Link to QoR results for a subset of NoC benchmarks. All QoR metrics are the same as the master branch. The placement time is almost the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for heterogeneous NoCs description in the architecture file. It is now possible to specify the latency of each NoC link and NoC router seperately. The user can also specify the bandwidth of each individual NoC link.
The architecture file reference needs to be updated to explaing how tag can be used. I think the code is done and the review process can begin. In meantime, I update the architecture file reference.
Description
The default latency and bandwidth for NoC links and routers are specified under tag with link_bandwidth, link_latency, and router_latency attributes. The user can override these default values for certain routers and links by adding an optional tag under tag.
Before this PR, some NoC-related cost calcualtion functions assumed the latency and bandwidth is the same for all NoC components. Now, these functions check if the latnecy or bandwidth is the same for all NoC components. When this not the case, thse functions query the bandwidth or the latency of NoC components separately.
Motivation and Context
Make the architecture description file syntax support heterogeneous NoC topologies.
How Has This Been Tested?
Has been tested with a toy architecture file.
Types of changes
Checklist: