Skip to content

Conversation

@grolmus
Copy link
Collaborator

@grolmus grolmus commented Sep 8, 2025

fix: #3628

Description

Added e2e test to reproduce the issue with loading custom fields on Session entities.

This is an in-progress fix that implements an e2e test which is currently expected to fail. The test demonstrates the problem where Session custom field relations are not being loaded correctly, but the root cause of the issue has not yet been isolated.

Breaking changes

None - this PR only adds a failing test case to document and reproduce the issue.

Test plugin location

The test plugin demonstrating the Session custom fields issue can be found in packages/dev-server/test-plugins/session-custom-fields/.

@vercel
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Nov 20, 2025 3:38pm
vendure-storybook Ready Ready Preview Comment Nov 20, 2025 3:38pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

@dlhck dlhck changed the title fix(core): session custom fields loading fix fix(core): session custom fields loading Sep 30, 2025
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom relation field on Session entity not returned when fetched

1 participant