Skip to content

fix(core): Let InitializerService hook OnApplicationBootstrap instead of OnModuleInit #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(core): Let InitializerService hook OnApplicationBootstrap instead of OnModuleInit #3638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c7c513
fix(core): Let InitializerService hook OnApplicationBootstrap instead…
DanielBiegler Jul 3, 2025
d3bdc6e
fix(core): Let ConfigModule initialize strategies and operations on m…
DanielBiegler Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/config/config.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Module, OnApplicationBootstrap, OnApplicationShutdown } from '@nestjs/common';
import { Module, OnApplicationShutdown, OnModuleInit } from '@nestjs/common';
import { ModuleRef } from '@nestjs/core';

import { ConfigurableOperationDef } from '../common/configurable-operation';
Expand All @@ -12,13 +12,13 @@ import { ConfigService } from './config.service';
providers: [ConfigService],
exports: [ConfigService],
})
export class ConfigModule implements OnApplicationBootstrap, OnApplicationShutdown {
export class ConfigModule implements OnModuleInit, OnApplicationShutdown {
constructor(
private configService: ConfigService,
private moduleRef: ModuleRef,
) {}

async onApplicationBootstrap() {
async onModuleInit() {
await this.initInjectableStrategies();
await this.initConfigurableOperations();
}
Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/service/initializer.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Injectable } from '@nestjs/common';
import { Injectable, OnApplicationBootstrap } from '@nestjs/common';

import { Logger } from '../config/logger/vendure-logger';
import { TransactionalConnection } from '../connection/transactional-connection';
Expand All @@ -24,7 +24,7 @@ import { ZoneService } from './services/zone.service';
* @docsCategory services
*/
@Injectable()
export class InitializerService {
export class InitializerService implements OnApplicationBootstrap {
constructor(
private connection: TransactionalConnection,
private zoneService: ZoneService,
Expand All @@ -39,7 +39,7 @@ export class InitializerService {
private stockLocationService: StockLocationService,
) {}

async onModuleInit() {
async onApplicationBootstrap() {
await this.awaitDbSchemaGeneration();
// IMPORTANT - why manually invoke these init methods rather than just relying on
// Nest's "onModuleInit" lifecycle hook within each individual service class?
Expand Down