Cluster Map Implementation #435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
boda26
commented
Oct 27, 2025
boda26
commented
- Cluster Map Object Implementation
- Refresh ClusterMap at the start of each fanout operation; fanout operations use targets from ClusterMap object
…nout and use targets from cluster map object Signed-off-by: Miles Song <[email protected]>
|
I think that it would be much more efficient if the engine allow subscription to a notification mechanism which is triggered once the slot assignment is changed. @murphyjacob4 , wdyt? |
vmsdk/src/cluster_map.cc
Outdated
| shard.slots_fingerprint = 0; | ||
| new_map->shards_[master_id] = std::move(shard); | ||
| } else { | ||
| it->second.owned_slots.insert(slot_set.begin(), slot_set.end()); |
There was a problem hiding this comment.
What if this list of nodes doesn't match the previous set?
vmsdk/src/cluster_map.cc
Outdated
| it->second.owned_slots.insert(slot_set.begin(), slot_set.end()); | ||
| } | ||
| } | ||
| new_map->is_cluster_map_full_ = assigned_slots.all(); |
There was a problem hiding this comment.
Where are the fingerprints for each shard being computed?
Comment on lines
384
to
403
| if (owned_count > 0) { | ||
| std::string owned_ranges; | ||
| int range_start = -1; | ||
| int range_end = -1; | ||
| for (size_t i = 0; i < k_num_slots; i++) { | ||
| if (map->owned_slots_[i]) { | ||
| if (range_start == -1) { | ||
| range_start = i; | ||
| range_end = i; | ||
| } else if (i == range_end + 1) { | ||
| range_end = i; | ||
| } else { | ||
| if (!owned_ranges.empty()) owned_ranges += ", "; | ||
| owned_ranges += | ||
| std::to_string(range_start) + "-" + std::to_string(range_end); | ||
| range_start = i; | ||
| range_end = i; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not save the slot ranges as they came in originally?
Signed-off-by: Miles Song <[email protected]>
|
Updated ClusterMap Implementation (significant change)
|
|
Todo: create a SocketAddress struct for ip and port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.