Add more fields to FT.INFO output #350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwware
force-pushed
the
ft-info-more-field
branch
from
2d5451e to
55b8ed4
Compare
allenss-amazon
approved these changes
Aug 26, 2025
hwware
force-pushed
the
ft-info-more-field
branch
from
55b8ed4 to
5c262d3
Compare
Signed-off-by: hwware <[email protected]>
Signed-off-by: hwware <[email protected]>
hwware
force-pushed
the
ft-info-more-field
branch
from
5c262d3 to
8a61567
Compare
|
Discussed in weekly meeting. We need to decide whether it makes sense to add dummy fields (which could silently break client-side logic) or if it makes sense to only add fields where we have some value and let customer apps break with syntactical parsing errors if they rely on such FT.INFO fields |
yairgott
requested changes
Sep 3, 2025
There was a problem hiding this comment.
Please follow the guidance: https://github.com/valkey-io/valkey-search/wiki/Weekly-meeting-2025-09-03#guidance-for-valkey-search-info-fields
FWIW, for most of these added fields with dummy values, the real values are either already captured or it's fairly easy to capture these values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more fields to align with RedisSearch output
Highlight part is what i add in this PR