fix: tracks only stored interned string #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: proost <[email protected]>
allenss-amazon
requested changes
Aug 17, 2025
There was a problem hiding this comment.
I think this is the wrong strategy. We should less clever, not more clever. The underlying problem is that you're not including the owned, but not shared strings in stringpool. Why not? I think if you just wrap the constructor and destructor of the InternString object with another IsolatedMemoryScope, then you'll solve the problem. It will means that InternString object which aren't entered in the pool get counted in the overall stat. But I don't see that as a problem.
Signed-off-by: proost <[email protected]>
Signed-off-by: proost <[email protected]>
…o fix-string-interning-store-memory-usage Signed-off-by: proost <[email protected]>
|
@allenss-amazon |
…o fix-string-interning-store-memory-usage Signed-off-by: lani_karrot <[email protected]>
…hub.com/proost/valkey-search into fix-string-interning-store-memory-usage Signed-off-by: proost <[email protected]>
…o fix-string-interning-store-memory-usage
Signed-off-by: proost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@allenss-amazon
I found missed part. there are interned string, but not stored in the store. but deallocation track all interned strings. so we should track only shared interned strings which are stored in the store.