Add cividis and oranges colorblind-friendly isochrone palettes (#191)#398
Open
AaravJalan wants to merge 3 commits intovalhalla:masterfrom
Open
Add cividis and oranges colorblind-friendly isochrone palettes (#191)#398AaravJalan wants to merge 3 commits intovalhalla:masterfrom
AaravJalan wants to merge 3 commits intovalhalla:masterfrom
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/398 |
nilsnolde
reviewed
Mar 24, 2026
Member
nilsnolde
left a comment
nilsnolde
left a comment
There was a problem hiding this comment.
hm, that issue should've been closed. we're already good IMO, not sure why we need more. we can merge, but then:
- please remove the oranges, that's not a nice color scale
- re-order so that colorblind-friendly come last
nilsnolde
requested changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Closes #191
👨💻 Changes proposed
Adds two new colorblind-friendly palette options to the isochrone color picker:
Also adds unit tests verifying palette presence and correct labeling.
📄 Note to reviewers
Note: I'm a GSoC 2026 applicant interested in the Valhalla and OSM routing projects.