Make required virtual methods abstract #826
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we have ignored the "isRequired" field for methods.
This property is always used alongside virtual methods and indicate that if you inherit its class with a script, it's mandatory to override this virtual methods (while others are just optional).
In such case, I made the method (and the class) abstract instead of giving it a dummy implementation.
A side effect is that several classes in the Godot API inherit those now "abstract" classes, so I had to create dummy implementation for those abstract methods.