Open
Conversation
2 tasks
…processing" in linux-arm64-windows-arm64-2 branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It depends on pull request #12
I have updated the GitHub Actions workflow to add support for
linux-arm64andwindows-arm64. I also updated the Vulkan version to1.4.335.0and the macOS runner tomacos-15(the currentmacos-13runner is deprecated and also does not work with the newer Vulkan version: actions/runner-images#13046.Currently, the
linux-arm64prebuilt binary is pulled from the following repository: https://github.com/jakoch/vulkan-sdk-arm, since the official LunarG SDK does not currently provide support for linux-arm64.windows-arm64also depends on updating to a newer version ofncnnin order to compile correctly, although it currently only works up to commit8b38cd8due to issues withcmake, thewindows-arm64build currently uses this commit for the time being.I haven't been able to test these builds because I don't have arm64 hardware (I've only tested on Ubuntu 24.04 and Windows 11, both x64). However, the GitHub Actions builds complete successfully and generate the binaries.
Regarding the CI workflow, I have changed it to use the release workflow but without publishing it.
Generated action: https://github.com/ollm/upscayl-ncnn/actions/runs/20928542745
Generated release: https://github.com/ollm/upscayl-ncnn/releases/tag/20260112-172057