Skip to content

fix: add rss mime type to text types#598

Open
dword-design wants to merge 1 commit into
unjs:mainfrom
dword-design:text-type-rss
Open

fix: add rss mime type to text types#598
dword-design wants to merge 1 commit into
unjs:mainfrom
dword-design:text-type-rss

Conversation

@dword-design

@dword-design dword-design commented Jun 25, 2026

Copy link
Copy Markdown

resolves #597

Alternative would be to turn the set into a set of regexes and have application\/([a-z]+\+)?xml in it, which would be rss-agnostic. I'm not sure which mime types exist that are formed like this, maybe someone can help ☺️.

Summary by CodeRabbit

  • Bug Fixes
    • RSS feed responses are now correctly recognized as text, improving how they’re handled and displayed instead of being treated as binary data.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

application/rss+xml is now recognized as a text response type, so RSS feeds are classified as "text" instead of falling through to "blob".

Changes

RSS response detection

Layer / File(s) Summary
Text MIME types
src/utils.ts
textTypes now includes application/rss+xml, and response-type detection classifies RSS responses as text.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nibbled a MIME leaf neat and bright,
RSS now reads as text just right.
No blob-hop detour, no fuzzy disguise,
Just tidy feeds for my twitchy eyes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the RSS MIME type fix.
Linked Issues check ✅ Passed The change matches issue #597 by treating application/rss+xml as text instead of Blob.
Out of Scope Changes check ✅ Passed The PR contains only the targeted MIME type update and no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSS feed with application/rss+xml returned as Blob instead of text

1 participant