-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor(voyager): rename consensus modules to finality modules #4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(voyager): rename consensus modules to finality modules #4597
Conversation
@marvelshan is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
Hey @marvelshan , can you please ensure ci passes? |
Sure! I'll take a look and make sure CI passes. Thanks for the heads-up! |
you'll need to run |
4edee78
to
b4247ed
Compare
Hi @benluelo , I encountered a problem during the test execution in the development environment. The test consistently times out, and I noticed some recurring errors in the logs. Here are the key points:
Do you have any suggestions on where I should start looking to resolve this issue? I'm especially wondering whether this could be related to the network configuration, the DNS resolver setup, or something in the test environment that causes the VM to be killed prematurely. Thanks in advance for your guidance! |
don't worry about the CI issues for now, the timeouts etc are unrelated to this PR. you will, however, need to reword your latest commit. |
5dc2f71
to
86fea16
Compare
@benluelo Thanks so much for your help and patience. I spent some time setting up the development environment due to compatibility issues between macOS and Nix. Since I’m not very familiar with Nix, I followed the project documentation and ended up using OrbStack to create a NixOS VM. There were some hiccups during the setup—like missing dependencies and OpenSSL build errors—but I managed to resolve them eventually. I really appreciate your guidance throughout this process. I’ve learned a lot from working on this PR, and I’m truly sorry for the repeated force-pushes that kept triggering CI. |
you need to sign all of your commits, and reword all commit messages to follow conventional commits as per our contributing guide |
86fea16
to
9ec15ab
Compare
I have signed all commits and updated the commit messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@benluelo Hi, I’ve just completed this issue and the related PR. I’m interested in learning more about the Union project and would love to continue contributing. I noticed there are some issues tagged as Easy and also saw the current issue @unionlabs/union/issues/4360. Do you have any recommendations on which issues I should work on next, or is it fine to pick any that interest me? If there are any issues you think would be especially suitable for someone new to the project, I’d appreciate your suggestions. Thank you! |
4360 is a good simple one if you're interested. i'll write more of an explanation in the issue |
Thanks. Appreciate it! |
Which issue does this PR close?
closes #4374
Overview
This PR renames the
voyager/modules/consensus
directory to finality and updates all related package names and references to better reflect their actual functionality.Why
As identified in issue #4374, the current "consensus" naming is a legacy artifact from an earlier design. These modules now only provide information about finality rather than handling the full consensus process. This renaming improves code clarity and removes potential confusion for developers.
Implementation Details
voyager/modules/consensus
→ finalityvoyager-consensus-module-X
→voyager-finality-module-X
Modules Affected