Skip to content

fix: detect git_push_create_all_pipelines feature flag correctly #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

fix: detect git_push_create_all_pipelines feature flag correctly #214

merged 4 commits into from
Apr 8, 2025

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 8, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Improved feature flag detection and error handling for more reliable system behavior.
    • Corrected type configuration to ensure proper referencing of legacy definitions.

  • Chores

    • Updated dependency versions and adjusted package settings for improved development stability.

@JounQin JounQin requested a review from Copilot April 8, 2025 03:24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5d2a111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 8, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces two changeset patches that address issues in the changesets-gitlab configuration. One patch fixes the detection of the git_push_create_all_pipelines feature flag while the other corrects the legacy types reference. Additionally, the package.json file is updated to change the type definitions path and bump several development dependencies. The runPublish function in src/run.ts is refactored to explicitly extract the active property from the feature flag API response while maintaining proper error handling.

Changes

File(s) Summary
.changeset/angry-phones-poke.md
.changeset/silly-mugs-prove.md		 Introduces changeset patches for the changesets-gitlab category: fixes the detection of the git_push_create_all_pipelines feature flag and corrects legacy types reference.
package.json Updates the type definitions path (from ./lib/index.d.ts to ./index.d.cts) and bumps devDependencies (@1stg/common-config, @pkgr/rollup, eslint, typescript).
src/run.ts Refactors the runPublish function to use a .then() for extracting the active property from the API response before handling errors with .catch().

Sequence Diagram(s)

sequenceDiagram
    participant R as runPublish Function
    participant F as FeatureFlags API

    R->>F: Call show('git_push_create_all_pipelines')
    alt Successful Response
      F-->>R: Return { active: true/false }
      R->>R: Extract and use `active` value
    else Error Occurred
      F-->>R: Return error
      R->>R: Catch error and default to false
    end
Loading

Possibly related PRs

Poem

I hop through lines of updated code,
Fixing flags where secrets once abode.
Types now point to a brand new way,
With dev deps fresh to brighten the day.
I’m a clever rabbit on a coding spree! 🐇
Happy patches hopping, wild and free!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/run.ts

Oops! Something went wrong! :(

ESLint: 9.24.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d3b7d9 and 5d2a111.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • .changeset/angry-phones-poke.md (1 hunks)
  • .changeset/silly-mugs-prove.md (1 hunks)
  • package.json (3 hunks)
  • src/run.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@socket-security Socket Security
Copy link

socket-security bot commented Apr 8, 2025 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@1stg/[email protected] ➜ 12.0.0 None 0 48 kB jounqin
npm/@1stg/[email protected] ➜ 1.0.3 None 0 6.57 kB jounqin
npm/@1stg/[email protected] ➜ 8.4.0 None 0 85.9 kB jounqin
npm/@1stg/[email protected] ➜ 4.0.8 None 0 37.3 kB jounqin
npm/@1stg/[email protected] ➜ 4.0.3 None 0 0 B
npm/@1stg/[email protected] ➜ 5.0.0 None 0 31.8 kB jounqin
npm/@1stg/[email protected] ➜ 3.0.3 None 0 12.4 kB jounqin
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 93.1 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 155 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 47.1 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 823 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 32 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 26.8 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 178 kB rel1cx
npm/@eslint-react/[email protected] ➜ 1.41.0 None 0 32.3 kB rel1cx
npm/@eslint/[email protected] ➜ 9.24.0 None 0 14.4 kB eslintbot
npm/@pkgr/[email protected] ➜ 3.1.1 None +1 15.6 kB i1stg, jounqin
npm/@taplo/[email protected] ➜ 0.2.0 None 0 25.5 kB jounqin
npm/@taplo/[email protected] ➜ 0.5.0 None 0 35.6 MB jounqin
npm/@typescript-eslint/[email protected] ➜ 8.29.1 None +1 459 kB
npm/@typescript-eslint/[email protected] ➜ 8.29.1 None +1 171 kB
npm/@typescript-eslint/[email protected] ➜ 8.29.1 None 0 0 B
npm/@typescript-eslint/[email protected] ➜ 8.29.1 None 0 0 B
npm/@typescript-eslint/[email protected] ➜ 8.29.1 None 0 14.2 kB bradzacher, jameshenry
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.28 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.58 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.8 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.34 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.35 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.55 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.56 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 3.1 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 4.13 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.95 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.96 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 environment 0 2.07 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.44 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.52 MB jounqin
npm/@unrs/[email protected] ➜ 1.4.1 None 0 2.79 MB jounqin
npm/[email protected] ➜ 1.0.30001712 None 0 2.21 MB ai, beneb, caniuse-lite
npm/[email protected] None 0 11.4 kB wooorm
npm/[email protected] None 0 9.14 kB wooorm
npm/[email protected] None 0 8.43 kB wooorm
npm/[email protected] ➜ 1.5.134 None 0 0 B
npm/[email protected] ➜ 4.3.2 None 0 54.3 kB jounqin
npm/[email protected] ➜ 3.4.0 None 0 88 kB wooorm
npm/[email protected] ➜ 4.10.2 None 0 1.04 MB jounqin
npm/[email protected] ➜ 3.4.0 None +1 178 kB wooorm
npm/[email protected] ➜ 1.41.0 None 0 27.8 kB rel1cx
npm/[email protected] ➜ 1.41.0 None 0 132 kB rel1cx
npm/[email protected] ➜ 1.41.0 None 0 66.2 kB rel1cx
npm/[email protected] ➜ 1.41.0 None 0 42.1 kB rel1cx
npm/[email protected] ➜ 1.41.0 None 0 59.2 kB rel1cx
npm/[email protected] ➜ 1.41.0 environment 0 333 kB rel1cx
npm/[email protected] None 0 7.39 kB wooorm
npm/[email protected] None 0 6.89 kB wooorm
npm/[email protected] None 0 7.28 kB wooorm
npm/[email protected] ➜ 0.19.0 None 0 41.1 kB jounqin
npm/[email protected] ➜ 0.16.1 None 0 52.1 kB jounqin
npm/[email protected] ➜ 2.0.4 None 0 23.2 kB jounqin
npm/[email protected] ➜ 8.29.1 None 0 81.6 kB jameshenry
npm/[email protected] ➜ 5.8.3 None 0 22.9 MB typescript-bot
npm/[email protected] ➜ 1.4.1 None 0 0 B

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 8, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 8, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/changesets-gitlab@214

commit: 5d2a111

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

📊 Package size report   0.1%↑

File Before After
lib/index.cjs 39.6 kB 0.07%↑39.6 kB
lib/run.js 8.8 kB 0.6%↑8.8 kB
lib/run.js.map 8.1 kB 0.8%↑8.1 kB
package.json 3.5 kB -0.09%↓3.5 kB
Total (Includes all files) 132.3 kB 0.1%↑132.4 kB
Tarball size 33.4 kB 0.2%↑33.4 kB
Unchanged files
File Size
index.d.cts 73 B
lib/api.d.ts 99 B
lib/api.js 899 B
lib/api.js.map 1.0 kB
lib/cli.d.ts 39 B
lib/cli.js 734 B
lib/cli.js.map 932 B
lib/comment.d.ts 247 B
lib/comment.js 9.4 kB
lib/comment.js.map 7.3 kB
lib/context.d.ts 74 B
lib/context.js 138 B
lib/context.js.map 228 B
lib/env.d.ts 70 B
lib/env.js 857 B
lib/env.js.map 778 B
lib/get-changed-packages.d.ts 305 B
lib/get-changed-packages.js 4.8 kB
lib/get-changed-packages.js.map 4.7 kB
lib/git-utils.d.ts 646 B
lib/git-utils.js 1.7 kB
lib/git-utils.js.map 2.2 kB
lib/index.d.ts 274 B
lib/index.js 241 B
lib/index.js.map 249 B
lib/main.d.ts 153 B
lib/main.js 3.6 kB
lib/main.js.map 3.1 kB
lib/read-changeset-state.d.ts 252 B
lib/read-changeset-state.js 650 B
lib/read-changeset-state.js.map 767 B
lib/run.d.ts 1.1 kB
lib/types.d.ts 1.2 kB
lib/types.js 44 B
lib/types.js.map 102 B
lib/utils.d.ts 1.6 kB
lib/utils.js 4.2 kB
lib/utils.js.map 4.8 kB
LICENSE 1.1 kB
README.md 11.8 kB

🤖 This report was automatically generated by pkg-size-action

JounQin
JounQin commented Apr 8, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JounQin JounQin merged commit b69af62 into main Apr 8, 2025
18 checks passed
@JounQin JounQin deleted the fix/feature_flag branch April 8, 2025 03:29
@github-actions github-actions bot mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JounQin