fix: truncate long URLs in Links table#4182
fix: truncate long URLs in Links table#4182avasis-ai wants to merge 1 commit intoumami-software:masterfrom
Conversation
… being pushed off-screen Closes umami-software#4136 Adds width constraints to slug and url columns in LinksTable. The ExternalLink component already has truncate + overflow:hidden, but the DataColumn itself was unconstrained, allowing long URLs to push action buttons off-screen.
|
@abhayjnayakk is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR fixes unconstrained column widths in Confidence Score: 5/5Safe to merge — minimal, targeted fix with no breaking changes. The change adds two width props to existing DataColumn components, consistent with how the created and action columns are already constrained. The ExternalLink component already handles truncation and tooltip display, so no new logic is introduced. No regressions or issues identified. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[DataTable renders columns] --> B[name column — flexible width]
A --> C[slug column — width 25%]
A --> D[url column — width 30%]
A --> E[created column — width 200px]
A --> F[action column — width 100px, optional]
C --> G[ExternalLink]
D --> H[ExternalLink]
G --> I[Row overflow=hidden\nText truncate\ntitle=href tooltip]
H --> I
I --> J[Long URLs truncated with ellipsis\nAction buttons remain visible]
Reviews (1): Last reviewed commit: "fix: truncate long URLs in Links table t..." | Re-trigger Greptile |
Summary
width="25%"to the Link column andwidth="30%"to the Destination URL column inLinksTable.tsxExternalLinkcomponent already hastruncate+overflow: hidden, but theDataColumnitself was unconstrained, allowing long URLs to push the edit/delete action buttons off-screenCloses #4136
Before
Long URLs expand the table cells with no constraint, pushing action buttons outside the visible viewport. Users had to use browser DevTools to access edit/delete.
After
Link and Destination URL columns are now width-constrained. The
ExternalLinkcomponent's existingtruncateprop kicks in, showing ellipsis for long URLs while keeping action buttons always visible.Testing
DataColumnacceptswidthprop (already used bycreatedcolumn withwidth="200px")ExternalLinkalready handles truncation viaText truncate+Row overflow="hidden"