Skip to content

fix: truncate long URLs in Links table#4182

Open
avasis-ai wants to merge 1 commit intoumami-software:masterfrom
avasis-ai:fix/links-table-truncate-urls
Open

fix: truncate long URLs in Links table#4182
avasis-ai wants to merge 1 commit intoumami-software:masterfrom
avasis-ai:fix/links-table-truncate-urls

Conversation

@avasis-ai
Copy link
Copy Markdown

Summary

  • Adds width="25%" to the Link column and width="30%" to the Destination URL column in LinksTable.tsx
  • The ExternalLink component already has truncate + overflow: hidden, but the DataColumn itself was unconstrained, allowing long URLs to push the edit/delete action buttons off-screen

Closes #4136

Before

Long URLs expand the table cells with no constraint, pushing action buttons outside the visible viewport. Users had to use browser DevTools to access edit/delete.

After

Link and Destination URL columns are now width-constrained. The ExternalLink component's existing truncate prop kicks in, showing ellipsis for long URLs while keeping action buttons always visible.

Testing

  • Verified DataColumn accepts width prop (already used by created column with width="200px")
  • ExternalLink already handles truncation via Text truncate + Row overflow="hidden"
  • No new dependencies or breaking changes

… being pushed off-screen

Closes umami-software#4136

Adds width constraints to slug and url columns in LinksTable.
The ExternalLink component already has truncate + overflow:hidden,
but the DataColumn itself was unconstrained, allowing long URLs
to push action buttons off-screen.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2026

@abhayjnayakk is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

This PR fixes unconstrained column widths in LinksTable by adding width="25%" to the slug/link column and width="30%" to the destination URL column. The ExternalLink component already applies overflow="hidden" and truncate — those props had no effect because the parent DataColumn had no width limit, allowing long URLs to expand indefinitely and push action buttons off-screen.

Confidence Score: 5/5

Safe to merge — minimal, targeted fix with no breaking changes.

The change adds two width props to existing DataColumn components, consistent with how the created and action columns are already constrained. The ExternalLink component already handles truncation and tooltip display, so no new logic is introduced. No regressions or issues identified.

No files require special attention.

Important Files Changed

Filename Overview
src/app/(main)/links/LinksTable.tsx Adds width="25%" to the slug column and width="30%" to the url column so ExternalLink's existing truncation/overflow logic can kick in and keep action buttons on-screen.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DataTable renders columns] --> B[name column — flexible width]
    A --> C[slug column — width 25%]
    A --> D[url column — width 30%]
    A --> E[created column — width 200px]
    A --> F[action column — width 100px, optional]

    C --> G[ExternalLink]
    D --> H[ExternalLink]

    G --> I[Row overflow=hidden\nText truncate\ntitle=href tooltip]
    H --> I

    I --> J[Long URLs truncated with ellipsis\nAction buttons remain visible]
Loading

Reviews (1): Last reviewed commit: "fix: truncate long URLs in Links table t..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long URLs push action buttons out of view in Links table - Can't suppress Link

2 participants