locking jekyll container version to 4.2.0.#43
Open
lindolo25 wants to merge 1 commit intoui-router:masterfrom
Open
locking jekyll container version to 4.2.0.#43lindolo25 wants to merge 1 commit intoui-router:masterfrom
lindolo25 wants to merge 1 commit intoui-router:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @christopherthielen! is been a while, but I've been working to fix the Docs when I had some time. This is the first of a series of PRs across several projects that focus on fixing the Docs generation scripts and containers. For now I will only focus on the @uirouter/angular package, but I'll check the rest later on.
This one is simple, is just replacing the :latest tag for :4.2.0 tag for jekyll container so the serve script works. the latest versions of the container is not working well with the current configuration of the project.
Also, as I've been building the docs locally I have a separated branch that contains the built _ng2_docs for v21. If you like I can add another PR, this will make it easy for you to publish the docs. Regardless, I'll be adding the changes needed to fix the tasks soon!
Kind Regards