-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for Scala.js #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/deriving/src/test/scala/shapeless3/deriving/type-classes.scala
Outdated
Show resolved
Hide resolved
modules/deriving/src/test/scala/shapeless3/deriving/type-classes.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Hmm I'm getting an error on
Is this a Mac thing? |
Have you got something standalone that reproduces that? |
I'm just running |
Interesting! I can't reproduce that on Linux. |
Looks like this is more about the JDK version. Starting with JDK12, So basically, another way to look at it is that Scala.js does not support building on JDK12. |
It should be possible to avoid the reference to Perhaps Scala 3 should also consider |
Except that |
This is mainly the addition of Scala.js build/publish infrastructure, however building for Scala.js revealed a couple of issues.
Typeable
was missing some instances which was only apparent when the corresponding tests failed for js.Eval
that @TimWSpence put together forFoldable#foldRight
test derivation blew up on js. When that was swapped out for a test dependency on cats-core it still failed, revealing that the use ofEval
in theFoldable
derivation was incorrect (a missingflatMap
). This will also be an issue with the prototypeFoldable
implementation in Kittens for Scala 3.