blocking and interruptible on Scala Native
#4378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #4323 |
It is! Edit: caveat, it landed in SN 0.5.7, which we are struggling to upgrade to. |
armanbilge
reviewed
Apr 14, 2025
armanbilge
reviewed
Apr 15, 2025
armanbilge
reviewed
Apr 15, 2025
core/jvm-native/src/main/scala/cats/effect/IOFiberPlatform.scala
Outdated
Show resolved
Hide resolved
durban
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4331
Fixes #4374
Closes #4360
This ports
interruptibleandblockingto the shared JVM/Native cross-build structure. I had to split apartIOCompaniona bit more since theCompletableFuturestuff is still JVM-only. Is that implemented on SN now? I'm assuming not. The other weird caveat came from the specialClosedByInterruptExceptionsemantics on JVM and its nonexistence on Native.