Skip to content

Commit e6f6209

Browse files
authored
Snake-case is_root, is_abstract in Type (#175)
## What is the goal of this PR? `is_root` and `is_abstract` are now snake cased in `Type`. ## What are the changes implemented in this PR? Protobuf convention is to use snake case. The casing affects the generated code. gRPC Java has been written with fallback logic to handle camelCase, but Python and Node.js do not. Before this change, we generated the following TypeScript code: ```ts export class Type extends jspb.Message { getIsroot(): boolean; setIsroot(value: boolean): Type; getIsabstract(): boolean; setIsabstract(value: boolean): Type; ``` After the change, these become `getIsRoot`, `setIsAbstract`, etc.
1 parent 16d1fb6 commit e6f6209

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

common/concept.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,8 +308,8 @@ message Type {
308308
string scope = 2;
309309
Encoding encoding = 3;
310310
AttributeType.ValueType value_type = 4;
311-
bool isRoot = 5;
312-
bool isAbstract = 6;
311+
bool is_root = 5;
312+
bool is_abstract = 6;
313313

314314
message Req {
315315
string label = 1;

0 commit comments

Comments
 (0)