Skip to content

Commit 16d1fb6

Browse files
authored
Fix Rust protocol failing to build in Cargo after an IDE sync (#174)
## What is the goal of this PR? We fixed an issue where the Rust protocol would fail to build in Cargo after an IDE sync (by bumping `vaticle_dependencies`) ## What are the changes implemented in this PR? The fix is in: - typedb/typedb-dependencies#400 Summary: The `typedb-protocol` crate depends heavily on generated sources (a Rust gRPC + Proto library). The Rust IDE sync tool would generate these sources if run in the `typedb-protocol` repo itself, but not if run from a different repo that depended on Protocol. We fixed that.
1 parent 4b07642 commit 16d1fb6

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.factory/automation.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,17 @@ build:
3131
bazel run @vaticle_dependencies//factory/analysis:dependency-analysis
3232
correctness:
3333
build:
34+
# TODO: use default machine once we delete the non-Rust protocols
35+
machine: 4-core-16-gb
3436
image: vaticle-ubuntu-22.04
3537
#NPM packages can't be built under RBE
3638
command: |
3739
bazel build //...
3840
bazel run @vaticle_dependencies//tool/checkstyle:test-coverage
3941
bazel test $(bazel query 'kind(checkstyle_test, //...)') --test_output=errors
4042
build-dependency:
43+
# TODO: use default machine once we delete the non-Rust protocols
44+
machine: 4-core-16-gb
4145
image: vaticle-ubuntu-22.04
4246
command: |
4347
dependencies/maven/update.sh

dependencies/vaticle/repositories.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ def vaticle_dependencies():
2121
git_repository(
2222
name = "vaticle_dependencies",
2323
remote = "https://github.com/vaticle/dependencies",
24-
commit = "ef99eda281717dafcb835cf924e4c673f46d7217", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
24+
commit = "16b46048ef215bdd162b2d734a04ad9b6d1545e2", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
2525
)

0 commit comments

Comments
 (0)