Fix side panel hotkeys breaking when opening records from table#19849
Open
abdulrahmancodes wants to merge 1 commit intomainfrom
Open
Fix side panel hotkeys breaking when opening records from table#19849abdulrahmancodes wants to merge 1 commit intomainfrom
abdulrahmancodes wants to merge 1 commit intomainfrom
Conversation
… side panel navigation - Removed unnecessary store dependencies and side panel state checks from `useResetFocusStackToRecordIndex` hook, enabling global hotkeys by default. - Streamlined the `useNavigateSidePanel` hook by consolidating side panel open checks, improving readability and maintainability.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
side-panel-focusis always restored in the focus stack when navigating within an already-open side panelglobalHotkeysConfigonrecord-indexfocus item that persisted after the side panel closedProblem
When clicking records in the table to open them in the side panel,
useLeaveTableFocuscalledresetFocusStackToRecordIndexwhich wiped the entire focus stack, including theside-panel-focusentry. SinceopenSidePanelearly-returned when the panel was already open,side-panel-focuswas never restored. Additionally,resetFocusStackToRecordIndexsetenableGlobalHotkeysWithModifiers: falseon the remainingrecord-indexitem when the side panel was open, and this stale config persisted after the panel closed, permanently blocking all hotkeys.Fix
useNavigateSidePanel.ts: MovepushFocusItemToFocusStackbefore theisSidePanelOpenedearly-return so the side panel's focus entry is always present in the stackuseResetFocusStackToRecordIndex.ts: Always setenableGlobalHotkeysWithModifiers: trueon therecord-indexitem. Hotkey scoping when the side panel is open is handled byside-panel-focussitting on top of the focus stackScreen.Recording.2026-04-19.at.7.54.28.AM.mov