NAS-141323 / 27.0.0-BETA.1 / Prevent truesearch dataset recursion when tiered#19096
Open
anodos325 wants to merge 1 commit into
Open
NAS-141323 / 27.0.0-BETA.1 / Prevent truesearch dataset recursion when tiered#19096anodos325 wants to merge 1 commit into
anodos325 wants to merge 1 commit into
Conversation
This commit disables truesearch dataset recursion when tiering globally enabled. This prevents unintended information disclosure for paths outside of SMB share roots.
bugclerk
changed the title
Contributor
creatorcary
reviewed
Jun 10, 2026
| What directories will it index. | ||
| """ | ||
| return await self.process_directories(await self.raw_directories()) | ||
| # When ZFS tiering is enabled the SMB server no longer traverses into nested dataset |
Contributor
There was a problem hiding this comment.
Just SMB or Webshare too?
themylogin
reviewed
Jun 10, 2026
themylogin
left a comment
themylogin
left a comment
Contributor
There was a problem hiding this comment.
Is having a default value for traverse dangerous? Some caller might forget to specify it and expose directories that should not be exposed…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit disables truesearch dataset recursion when tiering globally enabled. This prevents unintended information disclosure for paths outside of SMB share roots.