Conversation
Merged
20 tasks
There was a problem hiding this comment.
Pull request overview
This pull request adds input validation for model names in model management requests to prevent path traversal attacks. The validation ensures that model names used in load/unload operations cannot contain directory traversal sequences or path separators that could be exploited to access files outside the intended model repository.
Changes:
- Added ValidateModelName function to check for empty names and path traversal characters (.., /, )
- Integrated validation into LoadUnloadModel to protect the model loading/unloading entry point
- Updated copyright year to 2026
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mudit-eng
reviewed
Feb 23, 2026
yinggeh
reviewed
Feb 23, 2026
yinggeh
reviewed
Feb 27, 2026
whoisj
previously approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds input validation for model names in model management requests to prevent path traversal attacks. The validation ensures that model names used in the
loadoperation cannot contain directory traversal sequences or path separators that could be exploited to access files outside the intended model repository.CI: triton-inference-server/server#8672