Skip to content

Add documentation for tracing.sampling-ratio configuration property#28541

Open
hashroute3 wants to merge 3 commits intotrinodb:masterfrom
hashroute3:doc/add-tracing-sampling-ratio-config
Open

Add documentation for tracing.sampling-ratio configuration property#28541
hashroute3 wants to merge 3 commits intotrinodb:masterfrom
hashroute3:doc/add-tracing-sampling-ratio-config

Conversation

@hashroute3
Copy link
Member

@hashroute3 hashroute3 commented Mar 5, 2026

Description

Document the otel.tracing.sampling-ratio configuration property in the OpenTelemetry tracing documentation. This property already exists in the Airlift OpenTelemetryConfig class and controls the ratio of traces that are sampled and exported, but was not documented in the Trino docs.

Additional context and related issues

When tracing is enabled with the default sampling ratio of 1 (100%), high-traffic Trino deployments can generate excessive trace events, causing high load and cost on observability backends (e.g. Honeycomb, Jaeger). The workaround today is running an OpenTelemetry collector sidecar with sampling configuration, which adds unnecessary operational complexity.

Documenting otel.tracing.sampling-ratio allows users to reduce trace volume directly in Trino's config.properties without external workarounds.

The property is confirmed visible in Trino bootstrap logs:

Bootstrap    otel.tracing.sampling-ratio    1.0    1.0

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Mar 5, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mahendran Vasagam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hashroute3 hashroute3 force-pushed the doc/add-tracing-sampling-ratio-config branch from 0b40bfc to 46eb971 Compare March 5, 2026 04:58
@cla-bot cla-bot bot added the cla-signed label Mar 5, 2026
@hashroute3 hashroute3 force-pushed the doc/add-tracing-sampling-ratio-config branch from 2894aba to 5414b82 Compare March 5, 2026 17:11
@hashroute3 hashroute3 requested a review from ebyhr March 5, 2026 17:16
@hashroute3
Copy link
Member Author

@ebyhr Thank you for the review! I’ve addressed all the feedback you shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants