[BUGFIX] Process US regions without border countries#297
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR...
-nbccountry runs for Geofabrik IDs likeus/texasaligned with the tile names generated byCountryGeofabrik.us/texasso no-border processing usesus_texas, matching the split tile filenames.Considerations and implementations
When border-country processing is disabled,
CountryOsmDatapreviously kept the raw wanted map id inborder_countries. For US regions this meantus/texas, whileCountryGeofabrik.find_needed_countries()normalizes tile country names tous_texas. The later split and merge stages compare those names, so no country split files were added to the Osmosis merge command.This normalizes the no-border country key in the same way as the tile list and downloaded map filenames.
Fixes #288
How to test
git diff --checkPull Request Checklist