[FIX] Replace pkg_resources version parsing#296
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
nartex13
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR...
pkg_resources.parse_version()withpackaging.version.parsepackagingfor package installs, conda envs, and the pylint workflowFixes #295.
Considerations and implementations
pkg_resourcesis no longer available with recent setuptools releases, so the runtime import inwahoomc/setup_functions.pyprevents the CLI from starting.packaging.version.parseprovides the version comparison behavior needed here without depending onpkg_resources.How to test
Not run locally.
Static validation performed:
git diff --checkgit diff --check HEAD~1..HEADrg -n pkg_resources|parse_version|packaging wahoomc tests setup.cfg pyproject.toml conda_env .githubPull Request Checklist