Skip to content

[FIX] Replace pkg_resources version parsing#296

Draft
Mirochill wants to merge 1 commit into
treee111:developfrom
Mirochill:fix-295-drop-pkg-resources
Draft

[FIX] Replace pkg_resources version parsing#296
Mirochill wants to merge 1 commit into
treee111:developfrom
Mirochill:fix-295-drop-pkg-resources

Conversation

@Mirochill

@Mirochill Mirochill commented May 22, 2026

Copy link
Copy Markdown

This PR...

  • replaces pkg_resources.parse_version() with packaging.version.parse
  • declares packaging for package installs, conda envs, and the pylint workflow

Fixes #295.

Considerations and implementations

pkg_resources is no longer available with recent setuptools releases, so the runtime import in wahoomc/setup_functions.py prevents the CLI from starting. packaging.version.parse provides the version comparison behavior needed here without depending on pkg_resources.

How to test

Not run locally.

Static validation performed:

  • git diff --check
  • git diff --check HEAD~1..HEAD
  • rg -n pkg_resources|parse_version|packaging wahoomc tests setup.cfg pyproject.toml conda_env .github

Pull Request Checklist

  • Reviewed the Contributing Guidelines
  • Commits (and commit-messages) are understandable
  • Tested with macOS / Linux
  • Tested with Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg_resources not found

2 participants