chore: migrate avatar & bubble #5118
Merged
+939
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traefiker
force-pushed
the
chore/migrate-avatar-bubble
branch
from
586ce66 to
6452d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Avatar and Bubble to vanilla-extract.
Precision about Avatar: we have a Box wrapper for the Avatar component, that will have the avatar itself and the fallback (when applicable).
cssprops will be passed to the wrapper component. I didn't add polymorphic capability for this component, as I believe it wouldn't makes much sense; it would always be eitherimgorspan(for the fallback).