Skip to content

Fix/fusion/reduce swap dims#4867

Open
laggui wants to merge 4 commits intomainfrom
fix/fusion/reduce-swap-dims
Open

Fix/fusion/reduce swap dims#4867
laggui wants to merge 4 commits intomainfrom
fix/fusion/reduce-swap-dims

Conversation

@laggui
Copy link
Copy Markdown
Member

@laggui laggui commented Apr 22, 2026

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Closes #4815

Changes

Reduce broadcasted fuser requires contiguous inputs but having multi block local inputs might point to a reference that is SwapDims.

The current fix is to check for that condition, and refuse / close the fusion block.

Eventually we could improve fusion to support these cases.

Testing

All tests passing locally, except test_float_matmul_vecmat_transposed_fused (known issue, unrelated).

@laggui laggui requested a review from nathanielsimard April 22, 2026 18:32
@laggui laggui added the ci:test-gpu When applied to a Pull Request execute the `test-gpu.yml` workflow. label Apr 22, 2026
@bot-ember
Copy link
Copy Markdown
Member

🏷️ Workflow test-gpu enabled 🟢
🕒 Auto-run scheduled on updates
ℹ A run has been scheduled... please wait for the results

@bot-ember
Copy link
Copy Markdown
Member

❌ Workflow CI GPU:#4867 (run #389) failure!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.58%. Comparing base (87916c2) to head (ee50395).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rates/burn-cubecl-fusion/src/engine/trace/fuser.rs 0.00% 7 Missing ⚠️
...fusion/src/optim/reduce_broadcasted/fuser/block.rs 0.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (59.37%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (65.58%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4867      +/-   ##
==========================================
- Coverage   65.71%   65.58%   -0.14%     
==========================================
  Files        1153     1154       +1     
  Lines      169104   169595     +491     
==========================================
+ Hits       111126   111222      +96     
- Misses      57978    58373     +395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:test-gpu When applied to a Pull Request execute the `test-gpu.yml` workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Softmax on non-contiguous (transposed) input returns wrong values on cube-based backends

3 participants