This repository was archived by the owner on Apr 16, 2020. It is now read-only.
Implement function for creating errors with binary details field#191
Open
GeorgeHahn wants to merge 2 commits into
Open
Implement function for creating errors with binary details field#191GeorgeHahn wants to merge 2 commits into
details field#191GeorgeHahn wants to merge 2 commits into
Conversation
seanmonstar
reviewed
Jul 9, 2019
seanmonstar
left a comment
seanmonstar
left a comment
Contributor
There was a problem hiding this comment.
So, is the thinking to just accept raw bytes, and have the user determine what to serialize into them?
Contributor
Author
|
Correct; my hope was to at least make I just pushed a commit that adds the ability to populate details with an encoded protobuf. This is far more useful and may eliminate any desire for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a function to create
Statuserrors with thedetailsfield set.This is not a complete solution - other libraries offer ways to encode a protobuf into this field. This change will allow for some experimentation and manual implementation for error details.
Related: #136