Open
Conversation
Collaborator
|
This looks neat - could you add test cases for this? |
mattpocock
requested changes
Jun 24, 2023
Collaborator
mattpocock
left a comment
There was a problem hiding this comment.
Tests requested in comment above
Author
Done! |
Author
|
Hey @mattpocock just wondering if you had a chance to look at this one again. No rush, I'm sure you're quite busy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there. Great library. I've been using it to help speed up converting an old legacy codebase that had a ton of shady
as anycasting.One corner case I ran into:
Will throw
TS7006: Parameter 'p' implicitly has an 'any' typewhen it could have been inferred.Adding an inference for the parameter seems to have fixed it without breaking the rest of my tests. Not sure if it will cover all your use cases as well.
Cheers