-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fs: add io_uring open
operation
#7321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mox692/uring_dynamic_check
Are you sure you want to change the base?
Conversation
I ran a benchmark in commit d0dc6b2. settings$ uname -a
Linux mox692-ThinkPad-P51 6.8.0-59-generic 61-Ubuntu SMP PREEMPT_DYNAMIC Fri Apr 11 23:16:11 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
# On commit `d0dc6b2`,
# uring bench
$ RUSTFLAGS="--cfg tokio_unstable_uring" cargo bench open_many_files
# thread pool bench
$ cargo bench open_many_files Single-threaded runtime
Multi-threaded runtime
While performance improves in a current thread runtime, the results actually regress as the number of threads increases. Currently there is only one global ring in the runtime, so increasing threads may be causing lock contention. I'll look into whether I can reduce the lock contention. |
The main feedback I have here is that although it's ok to use |
Update: Sync with master and now the base branch is 7357. |
WIP.
This PR is based on the changes from #7320 and demonstrates how to support uring operations on top of that. This branch implements the
open
operation and has some tests.The implementation in this PR may be changed depending on the updates of the base PR.