Support set addr for UringCmd (#374) #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quininer
reviewed
Dec 15, 2025
| /// but some file/device command also need to pass an addr. | ||
| /// For example, the [ublk](https://docs.kernel.org/block/ublk.html#usage-requirements) | ||
| /// needs to set `addr` to some special value. | ||
| addr: Option<u64> = None, |
Member
There was a problem hiding this comment.
Should we add this for UringCmd80 as well?
Contributor
Author
There was a problem hiding this comment.
ublk seems only need UringCmd16 for now. But for completeness, I will add for UringCmd80.
huang-jl
force-pushed
the
support-addr-for-cmd
branch
from
fa78328 to
fcde1cc
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin requirement comes from #374.
Some device-specific commands need to set
io_uring_sqe.addrto special value, such as ublk.