Bugfix/multiple fonts #56
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumptions
The output is now sorted by rune and ensures uniqueness.
This matches the assumptions made by const2bit.GetGlyph,
which relies on binary search and does not support duplicate runes.
Summary
This PR fixes the unstable font generation when using multiple font files.
Why
Previously, glyphs could be duplicated or appear in non-deterministic order,
which caused incorrect behavior.
For example, NotoSansJP-Regular.ttf and NotoSansKR-Regular.ttf are CJK fonts
that embed very large character sets. Each font includes not only Japanese or
Korean characters but also full sets of Latin, Greek, Cyrillic, and other
Euro-zone glyphs. As a result, there is a huge overlap (e.g. punctuation,
Latin letters).
When these fonts are combined, many runes appear multiple times and the generated
order becomes non-deterministic. This PR resolves these issues by enforcing
uniqueness and sorting.