Skip to content

Make locality thinning grids smaller #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iandees merged 10 commits into from
Jan 28, 2022
Merged

Make locality thinning grids smaller #2040

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
18f669d
Make locality thinning grids smaller
iandees Jan 3, 2022
e0fe150
Reduce grid_width a bit
iandees Jan 4, 2022
9baf3ff
Merge branch 'master' into dees/tweak-thinning
iandees Jan 4, 2022
9d88279
Update integration test for new queres.yaml
iandees Jan 4, 2022
d63722d
Multiply by 4 to account for metatile size
iandees Jan 4, 2022
50bb898
Multiple the original values by 4 instead of the values that were alr…
iandees Jan 5, 2022
d602ff1
Switch z8-z9 to grid_width 6 (scaled to a 4x4 metatile)
iandees Jan 7, 2022
67ac148
Move to ground units instead of number of subdivisions
iandees Jan 26, 2022
8311154
Update integration test
iandees Jan 28, 2022
2eca280
Switch from 'grid_width' to 'grid_width_meters'
iandees Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration-test/1999-keep-n-gridded.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_thinned_tokyo(self):
# We should thin out most of the data at zoom 8
self.assert_n_matching_features(
8, 227, 100, 'places',
{'kind': 'locality'}, 134)
{'kind': 'locality'}, 34)

# Zoom 11 should have Tokyo
self.assert_has_feature(
Expand Down
6 changes: 3 additions & 3 deletions queries.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ post_process:
end_zoom: 9
items_matching: { kind: locality }
max_items: 1
grid_width: 3
grid_width: 12
sorting_keys:
- { sort_key: 'min_zoom', reverse: False }
- { sort_key: 'collision_rank', reverse: False }
Expand All @@ -1065,7 +1065,7 @@ post_process:
end_zoom: 11
items_matching: { kind: locality }
max_items: 1
grid_width: 6
grid_width: 24
sorting_keys:
- { sort_key: 'min_zoom', reverse: False }
- { sort_key: 'collision_rank', reverse: False }
Expand All @@ -1078,7 +1078,7 @@ post_process:
end_zoom: 13
items_matching: { kind: locality }
max_items: 1
grid_width: 12
grid_width: 48
sorting_keys:
- { sort_key: 'min_zoom', reverse: False }
- { sort_key: 'collision_rank', reverse: False }
Expand Down