[ALOY-1714] Allow ~/ to be used as a shortcut for WPATH() in xml view attributes#951
Open
brentonhouse wants to merge 7 commits intotidev:mainfrom
Open
[ALOY-1714] Allow ~/ to be used as a shortcut for WPATH() in xml view attributes#951brentonhouse wants to merge 7 commits intotidev:mainfrom
brentonhouse wants to merge 7 commits intotidev:mainfrom
Conversation
ewanharris
reviewed
Feb 10, 2020
Member
ewanharris
left a comment
There was a problem hiding this comment.
I think we're going to faces the same challenges as #953 here, this currently will only work in views. If we're adding syntactic sugar like this I'd rather see it work in the majority of places rather than a single one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/ALOY-1714
Allow
~/be used as a shortcut for this so thatWPATH()is no longer required when using with XML View attributes