Skip to content

Release 1.98.1 to master#1973

Merged
clintonium-119 merged 14 commits into
masterfrom
release-1.98.1
Jul 8, 2026
Merged

Release 1.98.1 to master#1973
clintonium-119 merged 14 commits into
masterfrom
release-1.98.1

Conversation

@clintonium-119

Copy link
Copy Markdown
Member

No description provided.

henry-tp and others added 10 commits January 21, 2026 16:21
Per an IRB request, drop the token "anonymized"/"Anonymized" from
every user-facing string in the Big Data Donation Project opt-in
flow: consent/revoke dialogs, donation form, slideshow, new-patient
prompt, and app banner. Syncs the en/es/fr i18n keys and adds a
regression test on getConsentText asserting the string never
reappears.
[WEB-4645] Remove mention of 'anonymized' from Big Data Donation Project copy app-wide
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad660957-335a-4c5f-9a37-e4e2b5c7c4d2

📥 Commits

Reviewing files that changed from the base of the PR and between 0dff813 and b7e0cda.

📒 Files selected for processing (3)
  • __tests__/unit/app/pages/patient/DataDonationConsentDialog.test.js
  • app/pages/patient/DataDonationConsentDialog.js
  • package.json

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Updated data donation and consent wording across the app to use clearer “your data” language.
    • Added a scroll reminder in the consent flow until the document has been read.
  • Bug Fixes

    • Aligned donation and revoke-consent prompts with the latest on-screen text.
    • Updated English, Spanish, and French labels to keep translations consistent.
  • Chores

    • Bumped the app version to 1.98.1.

Walkthrough

This PR removes “anonymized” wording from data donation copy in patient-facing flows, updates the related consent behavior and tests, and adjusts English, Spanish, and French translations plus the translation update script.

Changes

Data donation copy and consent flow update

Layer / File(s) Summary
Consent form and dialog copy
app/pages/patient/DataDonationForm.js, app/pages/patient/DataDonationConsentDialog.js, app/pages/patient/DataDonationRevokeConsentDialog.js, __tests__/unit/app/pages/patient/DataDonationForm.test.js
Consent prompts, dialog questions/descriptions, and input labels remove “anonymized” wording; tests are updated to match the new phrasing.
Consent scroll prompt behavior
app/pages/patient/DataDonationConsentDialog.js, __tests__/unit/app/pages/patient/DataDonationConsentDialog.test.js
The consent-read value is reused for disabling the agreement checkbox, and the dialog conditionally shows a scroll-to-enable prompt that the test checks before and after scrolling.
Patient-new flow, banners, and slideshow copy
app/pages/patientnew/dataDonation.js, app/providers/AppBanner/appBanners.js, app/components/elements/SlideShow/DataDonationSlideShow.js, stories/SlideShow.stories.js, __tests__/unit/app/pages/patientnew/dataDonation.test.js
Step title, banner action text, and slideshow content are reworded to drop “anonymized”; the related heading test is updated accordingly.
Translation files and build script
locales/en/translation.json, locales/es/translation.json, locales/fr/translation.json, package.json
Donation strings are updated across all three locales, selected “Basal Rates” and “Job Title” entries are changed or removed, and the update-translations script is adjusted with a version bump.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the change intent is not described in a meaningful way. Add a short summary of the main user-facing changes, especially the data-donation copy and translation updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is broadly related to a release branch update, though it is less specific than the actual copy and translation changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release-1.98.1

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Comment @coderabbitai help to get the list of available commands.

@clintonium-119

Copy link
Copy Markdown
Member Author

/deploy qa5

@tidebot

tidebot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

clintonium-119 updated values.yaml file in qa5

@tidebot

tidebot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

clintonium-119 updated flux policies file in qa5

@tidebot

tidebot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

clintonium-119 deployed blip release-1.98.1 branch to qa5 namespace

clintonium-119 and others added 4 commits July 6, 2026 15:06
[WEB-4302] - Prompt to scroll in Data Donation dialog if consent not fully read
@clintonium-119 clintonium-119 merged commit 4b77f93 into master Jul 8, 2026
2 of 4 checks passed
@clintonium-119 clintonium-119 deleted the release-1.98.1 branch July 8, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants