fix(security): 2 improvements across 2 files#1953
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Potential XSS via dangerouslySetInnerHTML-equivalent pattern in mailto component - Security: Missing dependency array in useEffect hook Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Potential XSS via dangerouslySetInnerHTML-equivalent pattern in mailto component - Security: Missing dependency array in useEffect hook Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a reported security concern around constructing mailto: URLs from user-controlled props, and adjusts a React hook dependency list to be exhaustive.
Changes:
- Encode
emailAddressandemailSubjectwhen building themailto:URL inMailTo. - Update
Gate’suseEffectdependency array to includedispatchandonEnter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/components/mailto/mailto.js | Updates mailto URL construction to apply URL encoding to prop-derived values. |
| app/components/gate.js | Updates useEffect dependencies for correctness with React Hooks rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| render() { | ||
|
|
||
| var mailtoInfo = 'mailto:'+this.props.emailAddress+'?Subject='+this.props.emailSubject; | ||
| var mailtoInfo = 'mailto:' + encodeURIComponent(this.props.emailAddress) + '?Subject=' + encodeURIComponent(this.props.emailSubject); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:app/components/mailto/mailto.js:L16The MailTo component constructs a mailto URL by directly concatenating user-controlled props (emailAddress, emailSubject) without URL encoding. While not using dangerouslySetInnerHTML, the href attribute is constructed via string concatenation which could allow JavaScript protocol injection if props are attacker-controlled. The iframe with name='mailto' and src='about:blank' is also a potential security concern as it could be targeted.
Solution
Use URL encoding for emailAddress and emailSubject props. Consider using encodeURIComponent or a URL construction API. Validate that emailAddress matches expected email format before constructing URL.
Changes
app/components/mailto/mailto.js(modified)app/components/gate.js(modified)