Skip to content

LottieAudio: remove source log#44

Merged
hermet merged 1 commit into
mainfrom
jinny/audio
Jun 24, 2026
Merged

LottieAudio: remove source log#44
hermet merged 1 commit into
mainfrom
jinny/audio

Conversation

@tinyjin

@tinyjin tinyjin commented Jun 24, 2026

Copy link
Copy Markdown
Member

source info is redundant with embedded asset

Copilot AI review requested due to automatic review settings June 24, 2026 16:40
@tinyjin tinyjin requested a review from hermet as a code owner June 24, 2026 16:40
@tinyjin tinyjin self-assigned this Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the Lottie audio playback log output by removing the printed audio source string (info.src), since the PR notes the source is redundant when an asset is embedded.

Changes:

  • Update the [audio] play log line to omit src=....
  • Keep logging whether the audio is embedded vs external, plus offset and volume.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hermet hermet merged commit 3e5d9ef into main Jun 24, 2026
3 checks passed
@hermet hermet deleted the jinny/audio branch June 24, 2026 16:42
@hermet hermet added the refactoring Code refactoring / Exceptional handles label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code refactoring / Exceptional handles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants