Revert "fix: Use premultiplied WG color space in examples"#43
Closed
hermet wants to merge 1 commit into
Closed
Conversation
This reverts commit 29d63f7.
There was a problem hiding this comment.
Pull request overview
This PR reverts the previous change that switched WebGPU (WgCanvas) example render targets to a premultiplied color space, restoring the prior color space configuration used by the examples.
Changes:
- Update
WgCanvas::target()in the WebGPU multi-canvas example to usetvg::ColorSpace::ABGR8888S. - Update
WgCanvas::target()in the WebGPU window resize path to usetvg::ColorSpace::ABGR8888S.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/MultiCanvas.cpp |
Reverts the WebGPU offscreen target color space to ABGR8888S in the multi-canvas example loop. |
src/Example.h |
Reverts the WebGPU window canvas target color space to ABGR8888S on resize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #42