Skip to content

switch sdl2 to sdl3#16

Open
vtorri wants to merge 2 commits into
thorvg:mainfrom
vtorri:vtorri_sdl3
Open

switch sdl2 to sdl3#16
vtorri wants to merge 2 commits into
thorvg:mainfrom
vtorri:vtorri_sdl3

Conversation

@vtorri

@vtorri vtorri commented Jan 9, 2026

Copy link
Copy Markdown

No description provided.

@vtorri vtorri requested a review from hermet as a code owner January 9, 2026 22:32
@vtorri vtorri mentioned this pull request Jan 9, 2026
Open
hermet
hermet requested changes Jan 11, 2026
View reviewed changes
Comment thread src/Example.h
#include <thorvg-1/thorvg.h>
#include <SDL2/SDL.h>
#include <SDL2/SDL_syswm.h>
#include <thorvg.h>

@hermet hermet Jan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be changed.

Comment thread src/LottieExtension.cpp
*/

#include <thorvg-1/thorvg_lottie.h>
#include <thorvg_lottie.h>

@hermet hermet Jan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be changed

Comment thread src/LottieTweening.cpp
*/

#include <thorvg-1/thorvg_lottie.h>
#include <thorvg_lottie.h>

@hermet hermet Jan 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not change

@hermet hermet added the infrastructure Dev infrastructure label Jan 11, 2026
@vtorri

vtorri commented Jan 12, 2026

Copy link
Copy Markdown
Author

@hermet

$ pkgconf --cflags thorvg-1
-IC:/Documents/msys2_2/opt/thorvg/include/thorvg-1 -IC:/Documents/msys2_2/home/vincent.torri/ewpi_64/include/libpng16 -IC:/Documents/msys2_2/home/vincent.torri/
ewpi_64/include -IC:/Documents/msys2_2/ucrt64/bin/../include -IC:/Documents/msys2_2/home/vincent.torri/ewpi_64/include/webp

including thorvg-1/thorvg.h is not possible, hence my change, to at least compile

@hermet

hermet commented Jan 13, 2026

Copy link
Copy Markdown
Member

@vtorri I think it's a different story, you don't need to touch it in this PR.

@hermet hermet mentioned this pull request Jan 13, 2026
Open
@hermet hermet force-pushed the main branch 3 times, most recently from 45aefe3 to 1c5f8e3 Compare March 4, 2026 08:56
@hermet hermet force-pushed the main branch 3 times, most recently from 524743a to 6a6d1c1 Compare June 20, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermet hermet hermet requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@vtorri vtorri

Labels

infrastructure Dev infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtorri @hermet