Skip to content

Fix mktime() on PHP 8.2 and 8.3 #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Fix mktime() on PHP 8.2 and 8.3 #670

merged 1 commit into from
May 13, 2025

Conversation

cedric-anne
Copy link
Contributor

Before php/doc-en@57e27d2, the mktime() documentation was not mentioning the false return value on the mktime() function.

This false return value exists for years, see php/php-src@ed02f20#diff-975ac482adc74b487c6ac9d8dde32153e4b8a803ef8ec41e8d6594f0a042db69R410-R414

@silasjoisten silasjoisten merged commit 58578cf into thecodingmachine:master May 13, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/mktime-php-8.2-8.3 branch May 13, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silasjoisten silasjoisten silasjoisten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedric-anne @silasjoisten