Skip to content

Conversation

@MichaHoffmann
Copy link
Contributor

If one arm of a binary expression is a distribution point but not the binary expression itself, we would not distribute the other arm - this commit fixes this.

To fix this we have to refactor the distribution algorithm to compute the distribution points first and then do the actual modification of the AST.

@MichaHoffmann
Copy link
Contributor Author

$ go test ./engine/... -run=NONE -fuzz=FuzzDistributedEngineQuery -fuzztime=2m -v
=== RUN   FuzzDistributedEngineQuery
fuzz: elapsed: 0s, gathering baseline coverage: 0/2706 completed
fuzz: elapsed: 3s, gathering baseline coverage: 37/2706 completed
fuzz: elapsed: 6s, gathering baseline coverage: 73/2706 completed
fuzz: elapsed: 9s, gathering baseline coverage: 136/2706 completed
fuzz: elapsed: 12s, gathering baseline coverage: 212/2706 completed
fuzz: elapsed: 15s, gathering baseline coverage: 285/2706 completed
fuzz: elapsed: 18s, gathering baseline coverage: 349/2706 completed
fuzz: elapsed: 21s, gathering baseline coverage: 433/2706 completed
fuzz: elapsed: 24s, gathering baseline coverage: 504/2706 completed
fuzz: elapsed: 27s, gathering baseline coverage: 574/2706 completed
fuzz: elapsed: 30s, gathering baseline coverage: 645/2706 completed
fuzz: elapsed: 33s, gathering baseline coverage: 708/2706 completed
fuzz: elapsed: 36s, gathering baseline coverage: 776/2706 completed
fuzz: elapsed: 39s, gathering baseline coverage: 855/2706 completed
fuzz: elapsed: 42s, gathering baseline coverage: 925/2706 completed
fuzz: elapsed: 45s, gathering baseline coverage: 998/2706 completed
fuzz: elapsed: 48s, gathering baseline coverage: 1071/2706 completed
fuzz: elapsed: 51s, gathering baseline coverage: 1147/2706 completed
fuzz: elapsed: 54s, gathering baseline coverage: 1228/2706 completed
fuzz: elapsed: 57s, gathering baseline coverage: 1310/2706 completed
fuzz: elapsed: 1m0s, gathering baseline coverage: 1394/2706 completed
fuzz: elapsed: 1m3s, gathering baseline coverage: 1470/2706 completed
fuzz: elapsed: 1m6s, gathering baseline coverage: 1550/2706 completed
fuzz: elapsed: 1m9s, gathering baseline coverage: 1629/2706 completed
fuzz: elapsed: 1m12s, gathering baseline coverage: 1704/2706 completed
fuzz: elapsed: 1m15s, gathering baseline coverage: 1777/2706 completed
fuzz: elapsed: 1m18s, gathering baseline coverage: 1841/2706 completed
fuzz: elapsed: 1m21s, gathering baseline coverage: 1929/2706 completed
fuzz: elapsed: 1m24s, gathering baseline coverage: 2000/2706 completed
fuzz: elapsed: 1m27s, gathering baseline coverage: 2069/2706 completed
fuzz: elapsed: 1m30s, gathering baseline coverage: 2147/2706 completed
fuzz: elapsed: 1m33s, gathering baseline coverage: 2225/2706 completed
fuzz: elapsed: 1m36s, gathering baseline coverage: 2304/2706 completed
fuzz: elapsed: 1m39s, gathering baseline coverage: 2390/2706 completed
fuzz: elapsed: 1m42s, gathering baseline coverage: 2475/2706 completed
fuzz: elapsed: 1m45s, gathering baseline coverage: 2550/2706 completed
fuzz: elapsed: 1m48s, gathering baseline coverage: 2635/2706 completed
fuzz: elapsed: 1m51s, gathering baseline coverage: 2703/2706 completed
fuzz: elapsed: 1m52s, gathering baseline coverage: 2706/2706 completed, now fuzzing with 20 workers
fuzz: elapsed: 1m54s, execs: 2799 (32/sec), new interesting: 3 (total: 2709)
fuzz: elapsed: 1m57s, execs: 2922 (41/sec), new interesting: 9 (total: 2715)
fuzz: elapsed: 2m0s, execs: 3043 (40/sec), new interesting: 14 (total: 2720)
fuzz: elapsed: 2m2s, execs: 3043 (0/sec), new interesting: 14 (total: 2720)
--- PASS: FuzzDistributedEngineQuery (122.35s)
=== NAME  
PASS
ok  	github.com/thanos-io/promql-engine/engine	122.374s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants