Skip to content

Conversation

@michaely520
Copy link
Contributor

@michaely520 michaely520 commented Dec 3, 2025

What changed?

Wiring in #8658 but for operator api

Why?

Compatibility with CLI

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

in our functional test I commented out

	// Enable replication active -> standby
	_, err = activeCluster.AdminClient().AddOrUpdateRemoteCluster(
		ctx,
		&adminservice.AddOrUpdateRemoteClusterRequest{
			FrontendAddress:               standbyCluster.Host().RemoteFrontendGRPCAddress(),
			FrontendHttpAddress:           standbyCluster.Host().FrontendHTTPAddress(),
			EnableRemoteClusterConnection: true,
			EnableReplication:             true, // NOW enable replication
		})
	s.Require().NoError(err)

	// Enable replication standby -> active
	_, err = standbyCluster.AdminClient().AddOrUpdateRemoteCluster(
		ctx,
		&adminservice.AddOrUpdateRemoteClusterRequest{
			FrontendAddress:               activeCluster.Host().RemoteFrontendGRPCAddress(),
			FrontendHttpAddress:           activeCluster.Host().FrontendHTTPAddress(),
			EnableRemoteClusterConnection: true,
			EnableReplication:             true, // NOW enable replication
		})
	s.Require().NoError(err)

and used a locally built cli temporalio/cli#881 to enable, test passed

michaely520 added a commit to temporalio/api that referenced this pull request Dec 3, 2025
<!-- Describe what has changed in this PR -->
**What changed?**
Enable reading of new field added in AddOrUpdateRemoteClusterResponse as
these apparently aren't sharing/reusing a common proto for
reading/writing

<!-- Tell your future self why have you made these changes -->
**Why?**
Enabling reads from cli

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
na

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**
temporalio/temporal#8744

cli PR - temporalio/cli#881
temporal-cicd bot pushed a commit to temporalio/api-go that referenced this pull request Dec 3, 2025
<!-- Describe what has changed in this PR -->
**What changed?**
Enable reading of new field added in AddOrUpdateRemoteClusterResponse as
these apparently aren't sharing/reusing a common proto for
reading/writing

<!-- Tell your future self why have you made these changes -->
**Why?**
Enabling reads from cli

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
na

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**
temporalio/temporal#8744

cli PR - temporalio/cli#881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants